Skip to content

Conversation

@LiamGoodacre
Copy link

During d015efc some of the bindings were converted from physical keys to unicode. The binding for font size increase via = was missed. Therefore there was an inconsistency between font size increase and font size decrease. Decreasing with - would be relative to the keyboard layout, whereas increase required the physical = key.

Dedicated discussion: #8743
Original thread on: #8729 (comment)

I've ran zig build run to sanity check the behaviour and all seems well.
Let me know if there's anything else I need to do.


A work-around in the mean time is:

keybind = ctrl+equal=unbind
keybind = ctrl+==increase_font_size:1

During d015efc some of the bindings
were converted from physical keys to unicode. The binding for font size
increase via `=` was missed. Therefore there was an inconsistency
between font size increase and font size decrease. Decreasing with `-`
would be relative to the keyboard layout, whereas increase required the
physical `=` key.

Dedicated discussion: ghostty-org#8743
Original thread on: ghostty-org#8729 (comment)
Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Let's see what others think

@mitchellh
Copy link
Contributor

The comment above this implies we're doing this on purpose. I want to understand both sets of problems more before approving this.

@chrismo
Copy link

chrismo commented Oct 13, 2025

I have a related Discussion to this issue. Currently the increase_font_size keybind [src] is using unicode + and the next_tab keybind [src] is using physical_key bracket_right ... Dvorak maps + to bracket_right so these two keybindings are in conflict.

As a Dvorak/Mac user for ~15 years, I agree with this comment on a prior Dvorak discussion, that Ghostty should not be shipping physical keybinds for keys like bracket_right/bracket_left

@dwt
Copy link

dwt commented Nov 8, 2025

On a German layout, cmd - decreases the font size, but cmd + does not increase it again. This is broken on nightlies for at least a month now and I would really like a fix. The proposed workaround above also doesn't work on my system.

@dontwanttothink
Copy link

@dwt, I think this might be related to your issue, as my problem was identical: helix-editor/helix#14624. I originally wrote about it in the comments to this PR but deleted it because I wasn’t sure about the relevance.

One big factor to my confusion with this keybind was that the menu item asserted Cmd + would work —it does not, unless the menu bar is focused. Given that d015efc mentions making bindings ‘match macOS menus,’ perhaps this PR corrects that.

@dwt
Copy link

dwt commented Nov 10, 2025

@dontwanttothink Indeed, your comment helps and gives me a workaround for now with this snippet in my Ghostty config:

# Workaround for https://github.com/ghostty-org/ghostty/pull/8759
# Enables cmd+plus to work on german keyboard layouts
keybind=cmd+BracketRight=increase_font_size:1

Sorry, for grabbing your short name on GitHub. The long form of mine is onstensible: DontWannaTell - but I also really like yours. :)

@dwt
Copy link

dwt commented Nov 10, 2025

Looking at the code this pull request is trying to change, it only talks about the = key. Does this by any chance cover the + key too, or is this going to be another pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants