-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix default increase_font_size binding config from physical to unicode #8759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix default increase_font_size binding config from physical to unicode #8759
Conversation
During d015efc some of the bindings were converted from physical keys to unicode. The binding for font size increase via `=` was missed. Therefore there was an inconsistency between font size increase and font size decrease. Decreasing with `-` would be relative to the keyboard layout, whereas increase required the physical `=` key. Dedicated discussion: ghostty-org#8743 Original thread on: ghostty-org#8729 (comment)
pluiedev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Let's see what others think
|
The comment above this implies we're doing this on purpose. I want to understand both sets of problems more before approving this. |
|
I have a related Discussion to this issue. Currently the As a Dvorak/Mac user for ~15 years, I agree with this comment on a prior Dvorak discussion, that Ghostty should not be shipping physical keybinds for keys like |
|
On a German layout, cmd - decreases the font size, but cmd + does not increase it again. This is broken on nightlies for at least a month now and I would really like a fix. The proposed workaround above also doesn't work on my system. |
|
@dwt, I think this might be related to your issue, as my problem was identical: helix-editor/helix#14624. I originally wrote about it in the comments to this PR but deleted it because I wasn’t sure about the relevance. One big factor to my confusion with this keybind was that the menu item asserted Cmd + would work —it does not, unless the menu bar is focused. Given that d015efc mentions making bindings ‘match macOS menus,’ perhaps this PR corrects that. |
|
@dontwanttothink Indeed, your comment helps and gives me a workaround for now with this snippet in my Ghostty config: Sorry, for grabbing your short name on GitHub. The long form of mine is onstensible: DontWannaTell - but I also really like yours. :) |
|
Looking at the code this pull request is trying to change, it only talks about the |
During d015efc some of the bindings were converted from physical keys to unicode. The binding for font size increase via
=was missed. Therefore there was an inconsistency between font size increase and font size decrease. Decreasing with-would be relative to the keyboard layout, whereas increase required the physical=key.Dedicated discussion: #8743
Original thread on: #8729 (comment)
I've ran
zig build runto sanity check the behaviour and all seems well.Let me know if there's anything else I need to do.
A work-around in the mean time is: