Skip to content

Allow for default or inherited CWD in new window, tab and split surfaces (redone for GTK-NG) #9158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Allow for default or inherited CWD in new window, tab and split surfaces (redone for GTK-NG) #9158

wants to merge 11 commits into from
+93 −26

Conversation

@peterguy
Copy link
Contributor

@peterguy peterguy commented Oct 12, 2025 •
edited
Loading

Closes 1392

Add two boolean config settings:

  • tab-inherit-working-directory
  • split-inherit-working-directory

They mimic the existing window-inherit-working-directory, and it's interaction with working-directory.

This allows users to configure working directory inheritance independently for new tabs, windows, and split panes,
providing maximum flexibility for different workflow patterns.

Sample config entries

window-inherit-working-directory = false
tab-inherit-working-directory = true
split-inherit-working-directory = true

Authored with Amp
Relevant threads:

Behavior in macOS
https://share.cleanshot.com/7LsSGM53

Behavior in linux (Ubuntu)
https://share.cleanshot.com/qJf3Hp6w

@peterguy peterguy mentioned this pull request Oct 12, 2025
Closed
@peterguy peterguy marked this pull request as ready for review October 12, 2025 16:28
@peterguy peterguy requested review from a team as code owners October 12, 2025 16:28
pluiedev
pluiedev requested changes Oct 12, 2025
View reviewed changes
@dzuelke dzuelke mentioned this pull request Oct 13, 2025
Open
@peterguy peterguy requested a review from pluiedev October 13, 2025 19:29
@peterguy
Copy link
Contributor Author

I consolidated the enums; it builds and tests fine on macOS. My Linux VM is not building it currently - hangs on this step:

[186/191] steps
├─ run exe gbp (gbp.bin.z)
└─ run exe dwp (dwp.bin.z)

I'm working on getting Nix set up, but it's being recalcitrant.

If someone can try a build on Linux, let me know if it works (or not) for them.

@jcollie
Copy link
Member

jcollie commented Oct 14, 2025

I consolidated the enums; it builds and tests fine on macOS. My Linux VM is not building it currently - hangs on this step:

Are you using Zig 0.15.2 or 0.15.1? I believe that this is caused by breakage in zg caused by 0.15.2. You should either downgrade Zig to 0.15.1 or rebase your work on the latest main as the last thing that depended on zg was updated this morning.

@peterguy
Copy link
Contributor Author

peterguy commented Oct 14, 2025 •
edited
Loading

Are you using Zig 0.15.2 or 0.15.1?

0.15.2 0 - that's the version snap has.

Installed 0.15.1 via tarball and zig build behaves now.

Thanks for the pointer - I hadn't gotten to the point of questioning the version of zig yet. 🤦

@peterguy
Copy link
Contributor Author

Got zig build working on Linux (Ubuntu) using 0.15.1, and the enum consolidation tests out ok.

@peterguy peterguy force-pushed the inherit-cwd branch 3 times, most recently from 16a3435 to cba1cef Compare October 17, 2025 00:15
peterguy added 11 commits October 20, 2025 12:15
@peterguy
Add config entries for tab and split inheritance
25c01d7
@peterguy
Use config to determine cwd inheritance for windows, tabs, and splits
ecc732c 
- Define NewSurfaceContext enum (window, tab, split)
- Add shouldInheritWorkingDirectory helper function
- Thread surface context through newConfig and newSurfaceOptions
- Replace window-inherit-working-directory checks with context-aware logic
- Add context to embedded CAPI and GTK Surface structs
@peterguy
Add context field to C config struct
1c93bb6
@peterguy
Add C API function to handle new surfaces of different types
9f75790
@peterguy
Add the context to the Swift layer.
f3c1c69 
- Define NewSurfaceContext to match the Zig enum name and avoid magic numbers.
@peterguy
Add the surface context to the Surface's setParent
50e32f4 
In order to set the private context variable so that initiSurface can use it.
@peterguy
Use the new GTK Surface::setParent from the tab and split
f75d0be
@peterguy
Enable distinguishing between a new tab in a new window
58ccb0d 
(which should inherit based on the window setting),
and a new tab in an existing window
(which should inherit base on tab setting)
@peterguy
Add an enum type for the C API
da09250
@peterguy
Consolidate the several ghostty_surface_inherited_config
e7c651e 
functions back into a single function with a second parameter for the source context.
@peterguy
consolidated enums
3ec7154
@peterguy
Copy link
Contributor Author

@pluiedev thanks for the good feedback; can you take a look at the changes I made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pluiedev pluiedev Awaiting requested review from pluiedev

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow different window-inherit-working-directory behavior for tabs and windows

3 participants

@peterguy @jcollie @pluiedev