release: sign .deb files with a stronger algorithm #2165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been reported in #2028 that Git Credential Manager's `.deb` files cannot be validated with `debsig-verify`. A deeper investigation brought to light that the reason is a weak digest algorithm: `debsigs` calls `gpg --opengpg` which uses SHA-1, but `debsig-verify` rejects such weak signatures. This was actually already fixed in `debsigs`, but current Ubuntu versions will not get those fixes, being stuck with older `debsigs` versions. It's easy enough to work around, though, so let's do that. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been reported in #2028 that Git Credential Manager's
.debfiles cannot be validated withdebsig-verify. A deeper investigation brought to light that the reason is a weak digest algorithm:debsigscallsgpg --opengpgwhich uses SHA-1, butdebsig-verifyrejects such weak signatures.This was actually already fixed in
debsigs, but current Ubuntu versions will not get those fixes, being stuck with olderdebsigsversions.It's easy enough to work around, though, so just like microsoft/git#815, let's let Git Credential Manager's
releaseworkflow work around that.This closes #2028