feat: added bottom navbar to be able to navigate between videos easily #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demo_videoNav.mp4 |
|
@Paulie-Aditya Awesome! I noticed the videos on https://git-scm.com/videos are not in the correct order, but that has nothing to do with this PR. The way we put videos in two columns seems to be the problem here. I think we better use something like CSS grid for this. But again, that's unrelated to this change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a bottom navigation in videos so that user can easily navigate between videos by clicking next and previous buttons
Added safety checks so that prev/next buttons disappear based on the first and last videos respectively
Context
Addresses and solves #1711