Skip to content

Add new MISRA query suites and deprecate ambiguously named suites #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 4, 2024
Merged

Add new MISRA query suites and deprecate ambiguously named suites #729

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0e9758e
Add tags to represent which MISRA C version the rule was introduced in
lcartey Oct 2, 2024
4c9e048
MISRA C: Update query suites
lcartey Oct 2, 2024
b2e35a7
Add change note for MISRA C query suite
lcartey Oct 3, 2024
eb6e77c
Re-add MISRA default suite for C
lcartey Oct 3, 2024
ecb3a4a
Add new MISRA C++ query suites
lcartey Oct 3, 2024
b60dcd0
Add query suites for mandatory, required and advisory rules.
lcartey Oct 3, 2024
b06feab
Add MISRA C mandatory query suite
lcartey Oct 3, 2024
fee630b
MISRA C misra-default.qls update deprecation message, use import
lcartey Oct 3, 2024
c407583
Update schema validation with new tags
lcartey Oct 3, 2024
8b8efa5
Merge branch 'main' into lcartey/misra-update-suites
lcartey Oct 3, 2024
6da5c4d
Address whitespace issues
lcartey Oct 4, 2024
d464b7f
Merge branch 'main' into lcartey/misra-update-suites
lcartey Oct 4, 2024
5497cfa
Update NoReturn.json with MISRA C 2012 tags
lcartey Oct 4, 2024
4b9e9fd
Check MISRA C 2012 rules have MISRA C 2012 tags
lcartey Oct 4, 2024
aab6e17
Check MISRA C 2012 tags are not on other rules
lcartey Oct 4, 2024
0f89f16
Avoid confusion over double quotes in double quotes
lcartey Oct 4, 2024
8932310
Add tags to queries
lcartey Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions c/misra/src/codeql-suites/misra-c-2012-third-edition-with-amendment-2.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
- description: MISRA C 2012 - Third Edition, First Revision including Amendment 2
- qlpack: codeql/misra-c-coding-standards
- include:
kind:
- problem
- path-problem
tags contain:
- external/misra/c/2012/third-edition-first-revision
- external/misra/c/2012/amendment2
- exclude:
tags contain:
- external/misra/audit
- external/misra/default-disabled
12 changes: 12 additions & 0 deletions c/misra/src/codeql-suites/misra-c-advisory.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
- description: MISRA C 2012 (Advisory)
- qlpack: codeql/misra-c-coding-standards
- include:
kind:
- problem
- path-problem
tags contain:
- external/misra/obligation/advisory
- exclude:
tags contain:
- external/misra/audit
- external/misra/default-disabled
10 changes: 10 additions & 0 deletions c/misra/src/codeql-suites/misra-c-default.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
- description: MISRA C 2012 (Default)
- qlpack: codeql/misra-c-coding-standards
- include:
kind:
- problem
- path-problem
- exclude:
tags contain:
- external/misra/audit
- external/misra/default-disabled
12 changes: 12 additions & 0 deletions c/misra/src/codeql-suites/misra-c-mandatory.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
- description: MISRA C 2012 (Advisory)
- qlpack: codeql/misra-c-coding-standards
- include:
kind:
- problem
- path-problem
tags contain:
- external/misra/obligation/mandatory
- exclude:
tags contain:
- external/misra/audit
- external/misra/default-disabled
12 changes: 12 additions & 0 deletions c/misra/src/codeql-suites/misra-c-required.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
- description: MISRA C 2012 (Required)
- qlpack: codeql/misra-c-coding-standards
- include:
kind:
- problem
- path-problem
tags contain:
- external/misra/obligation/required
- exclude:
tags contain:
- external/misra/audit
- external/misra/default-disabled
12 changes: 2 additions & 10 deletions c/misra/src/codeql-suites/misra-default.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,2 @@
- description: MISRA C 2012 (Default)
- qlpack: codeql/misra-c-coding-standards
- include:
kind:
- problem
- path-problem
- exclude:
tags contain:
- external/misra/audit
- external/misra/default-disabled
- description: "DEPRECATED - MISRA C 2012 - use misra-c-default.qls instead"
- import: codeql-suites/misra-c-default.qls
1 change: 1 addition & 0 deletions c/misra/src/qlpack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ version: 2.36.0-dev
description: MISRA C 2012
suites: codeql-suites
license: MIT
default-suite-file: codeql-suites/misra-c-default.qls
dependencies:
codeql/common-c-coding-standards: '*'
codeql/cpp-all: 0.9.3
1 change: 1 addition & 0 deletions c/misra/src/rules/DIR-4-10/PrecautionIncludeGuardsNotProvided.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* correctness
* maintainability
* readability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/DIR-4-12/StdLibDynamicMemoryAllocationUsed.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* security
* correctness
* maintainability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/DIR-4-2/UsageOfAssemblyLanguageShouldBeDocumented.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @tags external/misra/id/dir-4-2
* maintainability
* readability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/DIR-4-3/LanguageNotEncapsulatedAndIsolated.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @tags external/misra/id/dir-4-3
* maintainability
* readability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/DIR-4-4/SectionsOfCodeShallNotBeCommentedOut.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* maintainability
* readability
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/DIR-4-5/IdentifiersInTheSameNameSpaceUnambiguous.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @tags external/misra/id/dir-4-5
* readability
* maintainability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/DIR-4-6/PlainNumericalTypeUsedOverExplicitTypedef.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* @precision high
* @problem.severity error
* @tags external/misra/id/dir-4-6
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/DIR-4-8/ObjectWithNoPointerDereferenceShouldBeOpaque.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* @tags external/misra/id/dir-4-8
* readability
* maintainability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/DIR-4-9/FunctionOverFunctionLikeMacro.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* external/misra/audit
* maintainability
* readability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-1-2/LanguageExtensionsShouldNotBeUsed.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @tags external/misra/id/rule-1-2
* maintainability
* readability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-1-3/OccurrenceOfUndefinedBehavior.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @tags external/misra/id/rule-1-3
* maintainability
* readability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-1-4/EmergentLanguageFeaturesUsed.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @tags external/misra/id/rule-1-4
* maintainability
* readability
* external/misra/c/2012/amendment2
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-10-1/OperandsOfAnInappropriateEssentialType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity warning
* @tags external/misra/id/rule-10-1
* maintainability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-10-1/PointerTypeOnLogicalOperator.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity warning
* @tags external/misra/id/rule-10-1
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-10-2/AdditionSubtractionOnEssentiallyCharType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @tags external/misra/id/rule-10-2
* maintainability
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-10-3/AssignmentOfIncompatibleEssentialType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @tags external/misra/id/rule-10-3
* maintainability
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-10-4/OperandsWithMismatchedEssentialTypeCategory.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @tags external/misra/id/rule-10-4
* maintainability
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-10-5/InappropriateEssentialTypeCast.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @tags external/misra/id/rule-10-5
* maintainability
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-10-6/AssignmentToWiderEssentialType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @tags external/misra/id/rule-10-6
* maintainability
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-10-7/ImplicitConversionOfCompositeExpression.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* @tags external/misra/id/rule-10-7
* maintainability
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-10-8/InappropriateCastOfCompositeExpression.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @tags external/misra/id/rule-10-8
* maintainability
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-11-1/ConversionBetweenFunctionPointerAndOtherType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-11-1
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-11-2/ConversionBetweenIncompleteTypePointerAndOtherType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-11-2
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-11-3/CastBetweenObjectPointerAndDifferentObjectType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @problem.severity error
* @tags external/misra/id/rule-11-3
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-11-4/ConversionBetweenPointerToObjectAndIntegerType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-11-4
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-11-5/ConversionFromPointerToVoidIntoPointerToObject.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-11-5
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-11-6/CastBetweenPointerToVoidAndArithmeticType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-11-6
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-11-7/CastBetweenPointerToObjectAndNonIntArithmeticType.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-11-7
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-11-8/CastRemovesConstOrVolatileQualification.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-11-8
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-11-9/MacroNullNotUsedAsIntegerNullPointerConstant.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* @problem.severity error
* @tags external/misra/id/rule-11-9
* readability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-12-1/ImplicitPrecedenceOfOperatorsInExpression.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @problem.severity warning
* @tags external/misra/id/rule-12-1
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-12-1/UnenclosedSizeofOperand.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* @problem.severity warning
* @tags external/misra/id/rule-12-1
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-12-2/RightHandOperandOfAShiftRange.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-12-2
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-12-3/CommaOperatorShouldNotBeUsed.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* @problem.severity recommendation
* @tags external/misra/id/rule-12-3
* readability
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-12-4/ConstantUnsignedIntegerExpressionsWrapAround.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* @tags external/misra/id/rule-12-4
* correctness
* security
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-12-5/SizeofOperatorUsedOnArrayTypeParam.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* @precision very-high
* @problem.severity error
* @tags external/misra/id/rule-12-5
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/mandatory
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-13-1/InitializerListsContainPersistentSideEffects.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-13-1
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-13-2/UnsequencedSideEffects.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* @problem.severity error
* @tags external/misra/id/rule-13-2
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/required
*/

Expand Down
1 change: 1 addition & 0 deletions c/misra/src/rules/RULE-13-3/SideEffectAndCrementInFullExpression.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* @tags external/misra/id/rule-13-3
* readability
* correctness
* external/misra/c/2012/third-edition-first-revision
* external/misra/obligation/advisory
*/

Expand Down
Loading
Loading