Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the modeling of Rust filesystem libraries (std::fs, async_std::fs, and tokio::fs) to enhance path injection detection capabilities. The main improvement is a significant expansion of path injection sinks along with some new sources and summaries.
Key changes:
- Expanded path injection sink coverage across all three filesystem libraries
- Added new source and summary models for file operations
- Enhanced test cases to verify the improved modeling
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/ql/test/query-tests/security/CWE-022/src/main.rs | Updated test cases with new path injection scenarios and corrected source annotations |
| rust/ql/test/query-tests/security/CWE-022/options.yml | Added tokio and async-std dependencies for testing |
| rust/ql/test/query-tests/security/CWE-022/TaintedPath.expected | Updated expected test results reflecting improved path injection detection |
| rust/ql/test/library-tests/dataflow/sources/test.rs | Enhanced filesystem source tests with additional scenarios and path operations |
| rust/ql/test/library-tests/dataflow/sources/TaintSources.expected | Updated expected source detection results |
| rust/ql/lib/codeql/rust/frameworks/tokio/fs.model.yml | Added comprehensive path injection sinks and canonicalize summaries for tokio::fs |
| rust/ql/lib/codeql/rust/frameworks/stdlib/fs.model.yml | Expanded path injection sinks and added path manipulation summaries for std::fs |
| rust/ql/lib/codeql/rust/frameworks/asyncstd/fs.model.yml | New model file for async-std filesystem operations |
| rust/ql/lib/change-notes/2025-08-22-fs.md | Added release note documenting the improvements |
hvitved
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve models of the Rust
std::fs,async_std::fsandtokio::fslibraries. There are some new sources and summaries, but the main change is probably a significant expansion of path injection sinks.