-
Notifications
You must be signed in to change notification settings - Fork 63.6k
Update username-considerations-for-external-authentication.md #37142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improved the explanation of the GHE.com shortcode/username relationship
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the explanation of the relationship between shortcodes and usernames for external authentication.
- Clarifies that while the shortcode is not visible in the UI, it is still appended to the usernames.
- Adds a note that the inclusion of the hidden shortcode reduces the username character limit for GitHub Enterprise Cloud with Data Residency.
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this update @eyalgal! ✨
I had a couple minor suggestions below. Let me know what you think and I can help merge this to main.
...aging-iam/iam-configuration-reference/username-considerations-for-external-authentication.md
Outdated
Show resolved
Hide resolved
...aging-iam/iam-configuration-reference/username-considerations-for-external-authentication.md
Outdated
Show resolved
Hide resolved
…e-considerations-for-external-authentication.md Co-authored-by: Joe Clark <[email protected]>
…e-considerations-for-external-authentication.md Co-authored-by: Joe Clark <[email protected]>
@jc-clark Thank you! |
...aging-iam/iam-configuration-reference/username-considerations-for-external-authentication.md
Outdated
Show resolved
Hide resolved
…e-considerations-for-external-authentication.md
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Improved the explanation of the GHE.com shortcode/username relationship
Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: