Skip to content

Conversation

eyalgal
Copy link
Contributor

@eyalgal eyalgal commented Mar 28, 2025

Improved the explanation of the GHE.com shortcode/username relationship

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Improved the explanation of the GHE.com shortcode/username relationship
@Copilot Copilot AI review requested due to automatic review settings March 28, 2025 20:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the explanation of the relationship between shortcodes and usernames for external authentication.

  • Clarifies that while the shortcode is not visible in the UI, it is still appended to the usernames.
  • Adds a note that the inclusion of the hidden shortcode reduces the username character limit for GitHub Enterprise Cloud with Data Residency.

Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 28, 2025
Copy link
Contributor

github-actions bot commented Mar 28, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
admin/managing-iam/iam-configuration-reference/username-considerations-for-external-authentication.md ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@github github deleted a comment from Copilot AI Mar 31, 2025
Copy link
Contributor

@jc-clark jc-clark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this update @eyalgal! ✨

I had a couple minor suggestions below. Let me know what you think and I can help merge this to main.

eyalgal and others added 2 commits March 31, 2025 11:32
…e-considerations-for-external-authentication.md

Co-authored-by: Joe Clark <[email protected]>
…e-considerations-for-external-authentication.md

Co-authored-by: Joe Clark <[email protected]>
@eyalgal
Copy link
Contributor Author

eyalgal commented Mar 31, 2025

@jc-clark Thank you!

jc-clark
jc-clark previously approved these changes Mar 31, 2025
@jc-clark jc-clark added this pull request to the merge queue Mar 31, 2025
@jc-clark jc-clark removed this pull request from the merge queue due to a manual request Mar 31, 2025
…e-considerations-for-external-authentication.md
@jc-clark jc-clark enabled auto-merge March 31, 2025 20:24
@jc-clark jc-clark added this pull request to the merge queue Mar 31, 2025
Merged via the queue into github:main with commit f7040a8 Mar 31, 2025
40 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants