Skip to content

Conversation

almaleksia
Copy link
Contributor

@almaleksia almaleksia commented Oct 8, 2025

Consolidating pull request review write tools.

create_and_submit_pull_request_review
create_pending_pull_request_review
submit_pending_pull_request_review
delete_pending_pull_request_review

are consolidated under

pull_request_review_write
with method parameter:
create
submit_pending
delete_pending

CreateAndSubmit and CreatePending merged under create method as they differ only by 2 parameters - event and body.

UPD: validated on curated datasets, no regressions accross models.

@almaleksia almaleksia force-pushed the almaleksia/consolidate-prs-write branch from 338e243 to 3b4eaf2 Compare October 8, 2025 14:55
@almaleksia almaleksia marked this pull request as ready for review October 9, 2025 08:49
@almaleksia almaleksia requested a review from a team as a code owner October 9, 2025 08:49
@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 08:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates multiple pull request review tools into a single unified tool. The purpose is to simplify the API by combining separate tools for creating, submitting, and deleting pull request reviews into one tool that uses a method parameter to determine the operation.

  • Replaced four separate tools (CreateAndSubmitPullRequestReview, CreatePendingPullRequestReview, SubmitPendingPullRequestReview, DeletePendingPullRequestReview) with one unified PullRequestReviewWrite tool
  • Updated tests to use the new consolidated tool with method-based operation selection
  • Updated documentation and instructions to reflect the new unified approach

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/github/tools.go Removed old tool registrations and added new unified tool
pkg/github/pullrequests.go Consolidated multiple tool functions into one with method dispatch
pkg/github/pullrequests_test.go Updated tests to use new tool name and method parameter
pkg/github/instructions.go Updated workflow instructions for new tool usage
pkg/github/toolsnaps/*.snap Updated/removed snapshots for tool definitions
README.md Updated documentation to reflect consolidated tool

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@almaleksia almaleksia force-pushed the almaleksia/consolidate-prs-write branch from de51fd6 to f978539 Compare October 9, 2025 08:55
JoannaaKL
JoannaaKL previously approved these changes Oct 9, 2025
@almaleksia almaleksia merged commit e5522fc into main Oct 10, 2025
16 checks passed
@almaleksia almaleksia deleted the almaleksia/consolidate-prs-write branch October 10, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants