Fix style parser to handle [ or ] in text without style#321
Open
andrewarrow wants to merge 29 commits intogizak:masterfrom
Open
Fix style parser to handle [ or ] in text without style#321andrewarrow wants to merge 29 commits intogizak:masterfrom
andrewarrow wants to merge 29 commits intogizak:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem with using [ or ] in text. Style Parser thinks you are going to supply a (style) block after and eats some of the chars:
#311
This PR re-writes the logic to look for pairs or "](" and only processes style when needed and leaves normal [ or ] in text alone.