Compose KeyTransport message correctly#162
Open
root-hardenedvault wants to merge 2 commits intogkdr:devfrom
Open
Compose KeyTransport message correctly#162root-hardenedvault wants to merge 2 commits intogkdr:devfrom
root-hardenedvault wants to merge 2 commits intogkdr:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #162 +/- ##
==========================================
- Coverage 22.25% 22.11% -0.14%
==========================================
Files 4 4
Lines 2103 2116 +13
==========================================
Hits 468 468
- Misses 1635 1648 +13
Continue to review full report at Codecov.
|
Simply calling omemo_message_create() cannot compose a valid KeyTransport message, which should at least have an ordinary "message" node, so we should first make up such message without a "body", then let omemo_message_prepare_encryption() of libomemo hamdle such case: gkdr/libomemo#33 Signed-off-by: HardenedVault <root@hardenedvault.net>
root-hardenedvault
force-pushed
the
omsg
branch
from
72e0057 to
27cceca
Compare
|
@gkdr: Have you seen this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply calling omemo_message_create() cannot compose a valid
KeyTransport message, which should at least have an ordinary "message"
node, so we should first make up such message without a "body", then
let omemo_message_prepare_encryption() of libomemo hamdle such case:
gkdr/libomemo#33
Signed-off-by: HardenedVault root@hardenedvault.net