Allow spreading records in type constructors for const values #5061
+1,879
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abs0luty
force-pushed
the
spreading-in-const-records
branch
3 times, most recently
from
b2242d8 to
200b09a
Compare
abs0luty
changed the title
abs0luty
changed the title
abs0luty
force-pushed
the
spreading-in-const-records
branch
4 times, most recently
from
50c471a to
df799f4
Compare
abs0luty
force-pushed
the
spreading-in-const-records
branch
from
df799f4 to
5d39a71
Compare
lpil
reviewed
Nov 10, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Thank you! This will be a relly nice addition. I've left a few questions in line.
Could you add a test that ensures that pub const dog = Animal(..alice) emits the "fieldless record update" warning please 🙏
abs0luty
force-pushed
the
spreading-in-const-records
branch
2 times, most recently
from
33a70f5 to
84302ed
Compare
abs0luty
force-pushed
the
spreading-in-const-records
branch
from
84302ed to
5f48b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.