Add support for websockets #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One quite prominent constraint with this implementation is all websocket endpoints must have the same state type. i can think of ways to design applications with this constraint in mind but its still worth bringing to attention |
|
The PR should be stable enough now for review, sorry for the after-draft commits as I saw flaws in the simulate module I submitted. Thanks in advance for the review! |
renatillas
force-pushed
the
websockets
branch
from
d1f811f to
bd5e9ce
Compare
|
Sorry! I wasn't sure if it my issue was going to be mentioned here too, If needed lmk and I'll remove it. Im really excited for this new feature <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only way I could implement websockets in a typesafe way, but introducing a breaking change on the response type. What do you think?