Feature/icon with label #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to better organize files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional segment type named
IconWithLabelSegmentwhich takes in an array of typeIconWithLabelwhich is a custom class that carries an icon of typeUIImageand a title of typeString.Most of the code inside
IconWithLabelSegmentis a combination of theLabelSegmentand theTitleSegmentso all of the features for those two segment types are carried over.Tested the constraints inside the custom
IconWithLabelViewused by theIconWithLabelSegmentto make sure the icon and label looks the way it should with different icon sizes and font sizes. Also what I found out is that the icon looks the best when it's size is half of the segment's height but that's still up to people who are using this to decide and customize.