configure IPv6 via ENV #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmta
reviewed
Mar 19, 2025
README.md
Outdated
| 3. Edit `.env` and set: | ||
| * `VELOCITA_URL`: the URL (e.g. `https://mydomain.tld`) on which Velocita is hosted | ||
| * `VELOCITA_IPV6_ENABLED`: set to `true` to enable IPv6 |
Owner
There was a problem hiding this comment.
You don't need to add this here; IPv6 being enabled is already the default. This section is meant to show some configuration options a lot of people might want to change when initially setting up the proxy.
proxy/templates/proxy.conf.erb
Outdated
| velocita_url = velocita_url.sub(/\/+$/, '') | ||
| end | ||
| tls_enabled = ENV['VELOCITA_TLS_ENABLED'] == 'true' | ||
| ipv6_enabled = ENV['VELOCITA_IPV6_ENABLED'] == 'true' |
Owner
There was a problem hiding this comment.
- Should be called
VELOCITA_IPV6_LISTEN - The default value should be
true, so maybe make this(ENV['VELOCITA_IPV6_ENABLED'] || 'true') == 'true'? - Could you document this new setting in
proxy/README.md? Specifically this section: https://github.com/gmta/velocita-proxy/tree/master/proxy#configuring-velocita
Author
There was a problem hiding this comment.
yeah, will be
ipv6_listen = (ENV['VELOCITA_IPV6_LISTEN'] || 'true') == 'true'
Author
There was a problem hiding this comment.
I completely overlooked the second readme
.env.dist
Outdated
| VELOCITA_URL=http://localhost:8080 | ||
| VELOCITA_HTTP_PORT=8080 | ||
| VELOCITA_HTTPS_PORT=8443 | ||
| VELOCITA_IPV6_ENABLED=true |
Owner
There was a problem hiding this comment.
Suggested change
| VELOCITA_IPV6_ENABLED=true | |
| #VELOCITA_IPV6_LISTEN=true |
- Let's name this "listen" instead of "enabled" since it does not affect IPv6 connectivity as a whole, but just on which interfaces nginx is listening.
- The default value should be
true, so this is an optional setting.
Author
|
Did I miss something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding #2