-
Notifications
You must be signed in to change notification settings - Fork 34
Implemented the Summary method in cvpartition.m
#319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
A few remarks about your implementation.
|
|
FYI, the |
|
Your changes to single quotes won't work. Leave or error messages with double quotes as they were. Only use single quotes for character vectors in cell arrays. You should also adapt your actual code to use string arrays in the table for the sets (as it is in MATLAB). Always test your code before committing a PR. It saves us both a lot of time. Can you also add a few demo examples (see my previous comment). Thanks |
|
Yes, @pr0m1th3as i am working on it !! |
|
@pr0m1th3as, tried to do all the changes as said, apologies for the last commit because I forgot to put the PR on draft mode. |
coding style fix in demo file
c564557 to
c9a10b5
Compare
|
The demos in |
|
You can reuse some of the BISTs as demo as well. |
|
@pr0m1th3as yes i have tested them locally. If specific type of demos are needed like allowing the user to test each feature or something do tell me. |
Sure that would be nice |
|
Abut demos, one issue is that you should use seeding just before |
I have tried to fix those things in the file. The new demo file is working corresponding to all the changes in the datatypes package. Awaiting for your review. |
|
Have you tested against the latest dev of the It might take some time, but I will do my best to push everything to production today. Many thanks for your work on this. |
Yes I have tested it considering ur last commit
We can still do it again after all your work is done |
Closes #310