-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add DNS provider for AlibabaCloud ESA #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for adding support for this so quickly! I’ve tested the branch and found a couple of issues: 1. Wrong DNS API host 2. recordIDs field not initialized |
|
I’ve gone ahead and fixed these issues locally and opened a PR — hope it helps! ldez#3 |
|
The problem with the region is related to https://github.com/alibabacloud-go/esa-20240910/blob/7660e3aab2045d4820e4b83427a154efe0c79319/client/client.go#L27 The |
Thanks for the guidance, I ran it again, it worked perfectly. |
go mod tidyCloses #2702
Ping @AirboZH, can you run the command (with your domain, email, credentials, etc.)?
How to test this PR?
git clone https://github.com/ldez/lego.git cd lego git checkout feat/dns/aliesamake:make buildmake:go build -o dist/lego ./cmd/lego