build: Add golangci-lint checks #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement make validate to run golangci-lint checks and call it from the Test GitHub workflow. An initial set of rules have been enabled, and the violations fixed. Over time a larger number of rules will be enabled. Signed-off-by: Paulo Gomes <[email protected]>
| fs.s.New("/", 0755|os.ModeDir, 0) | ||
| _, err := fs.s.New("/", 0755|os.ModeDir, 0) | ||
| if err != nil { | ||
| log.Printf("failed to create root dir: %v", err) |
There was a problem hiding this comment.
Is this intended? You probably want to return the error here
There was a problem hiding this comment.
This was intentional as I didn't want to change the API on this PR, so the error is at least being logged. I was trying to keep the changes to a minimum while fixing the linter errors. The overall API will be revisited in future changes, and this revisited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement make validate to run golangci-lint checks and call it from the Test GitHub workflow.
An initial set of rules have been enabled, and the violations fixed. Over time a larger number of rules will be enabled.