Hardcode pg_rewind retrying (up-to 5m)#60
Merged
VSpike merged 1 commit intogocardless-v0.17.0+from Mar 22, 2022
Merged
Conversation
1. #14 Retry pg_rewind for up-to 5m after the first attempt. This allows us to handle the followed database booting for a moment before falling back to the more expensive pg_basebackup. This comes as a crappier alternative to [1], where we were creating proper configuration values. We want to try this before we attempt to create a more mature setup, as we intend to leave that work for whenever we upstream our cascading replication.
dyson
approved these changes
Mar 22, 2022
dyson
left a comment
dyson
left a comment
There was a problem hiding this comment.
Gave this a quick test and pg_rewind is working as expected. I'm not sure there is an easy way to verify the retry without testing in a sufficiently large and busy database but the code looks good to me.
Happy to merge this and if there are any issues it will be discovered quick enough during testing on larger clusters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry pg_rewind for up-to 5m after the first attempt. This allows us to
handle the followed database booting for a moment before falling back to
the more expensive pg_basebackup.
This comes as a crappier alternative to [1], where we were creating
proper configuration values. We want to try this before we attempt to
create a more mature setup, as we intend to leave that work for whenever
we upstream our cascading replication.