-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Add rasterize mesh texture demo #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5403476 to
b13af36
Compare
This comment was marked as resolved.
This comment was marked as resolved.
005fd75 to
9fb1896
Compare
d66e5c8 to
4f66c12
Compare
|
I ended up refactoring and deleting all the getters/setters for RIDs so that |
4f66c12 to
839216e
Compare
3b7a6d3 to
e967b85
Compare
5ccaeef to
3f037b4
Compare
Co-authored-by: A Thousand Ships <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This demo is lacking on the "being intuitive" side of things. If a user doesn't already know what this is or why they would want this, would this demo confuse them? Right now the demo just looks like "funny Godot logos stretched around". I think, at a minimum, the README needs significant elaboration, including why this is useful, meaning what use cases would need to rasterize a mesh texture. But ideally, we should try to do more than just the README. Maybe add text next to each item with a short explanation of what it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Add rasterize mesh texture demo.
Due to there is no way to automatically release RIDs when custom resource is released, I did some tricks on Sprite2D to make it able to run withResolved.@toolin editor. This demo works in 4.5, but spams some errors and use TextMesh within it doesn't work in 4.4.Closes #1192.