Skip to content

Conversation

@beicause
Copy link

@beicause beicause commented Apr 16, 2025

Add rasterize mesh texture demo.

Due to there is no way to automatically release RIDs when custom resource is released, I did some tricks on Sprite2D to make it able to run with @tool in editor. This demo works in 4.5, but spams some errors and use TextMesh within it doesn't work in 4.4. Resolved.

Closes #1192.

@beicause beicause force-pushed the rasterize-mesh-texture branch 4 times, most recently from 5403476 to b13af36 Compare April 16, 2025 18:26
@beicause

This comment was marked as resolved.

@beicause beicause force-pushed the rasterize-mesh-texture branch 2 times, most recently from 005fd75 to 9fb1896 Compare April 18, 2025 11:14
@beicause beicause force-pushed the rasterize-mesh-texture branch 3 times, most recently from d66e5c8 to 4f66c12 Compare April 27, 2025 10:55
@beicause
Copy link
Author

beicause commented Apr 27, 2025

I ended up refactoring and deleting all the getters/setters for RIDs so that NOTIFICATION_PREDELETE could work, and resolved the weird issue mentioned above. Also added a test for 2D mesh.

@beicause beicause force-pushed the rasterize-mesh-texture branch from 4f66c12 to 839216e Compare April 27, 2025 11:44
@beicause beicause force-pushed the rasterize-mesh-texture branch 3 times, most recently from 3b7a6d3 to e967b85 Compare July 27, 2025 17:28
@beicause beicause force-pushed the rasterize-mesh-texture branch from 5ccaeef to 3f037b4 Compare July 29, 2025 11:40
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This demo is lacking on the "being intuitive" side of things. If a user doesn't already know what this is or why they would want this, would this demo confuse them? Right now the demo just looks like "funny Godot logos stretched around". I think, at a minimum, the README needs significant elaboration, including why this is useful, meaning what use cases would need to rasterize a mesh texture. But ideally, we should try to do more than just the README. Maybe add text next to each item with a short explanation of what it is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appearance of the demo doesn't match the screenshot. When I run it, there is a 3D mesh in the background:

Screenshot 2025-10-01 at 9 41 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new RenderingDevice rendering pipeline demo

5 participants