-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Add a camera feed demo in misc #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
32d07e5 to
d7aa707
Compare
d7aa707 to
31daada
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the demo requires 4.5 (even on unsupported platforms), as it references the monitoring_feeds property which doesn't exist on 4.4.1. This is not essential to fix to merge (it's fine for this demo to be 4.5+), but I thought I'd mention nonetheless.
Some feedback:
- The demo should be switched to the Compatibility rendering method if it doesn't use features exclusive to Forward+/Mobile.
- The demo's folder should be renamed from
camerafeedtocamera_feed. application/run/low_processor_modeshould be enabled in the Project Settings to reduce CPU/GPU utilization when idle.
95f148b to
7c11b39
Compare
|
@Calinou
|
|
The demo should use a lower window size on desktop platforms. Otherwise, on a 1080p display, it'll look like this when run from the editor with game window embedding enabled: You can do this by changing Window Width Override and Window Height Override to |
7c11b39 to
c48aa42
Compare
|
bea0171 to
aea91ff
Compare
aea91ff to
292547b
Compare
292547b to
91e9758
Compare
|
@AThousandShips Address review comments. |
cd10789 to
5d13712
Compare
Co-authored-by: Jason Kuo <[email protected]>
5d13712 to
0e376f2
Compare
|
I've tested the demo on macOS with 4.5.stable and I noticed that while the camera name appears, I can't choose any format:
After clicking Reload, I see a permission prompt. When I accept it, the LED next to the webcam lights up, but I still don't see anything. I don't see any errors in the terminal. This occurs regardless of how I'm running Godot (it's the official 4.5 .app bundle, I've tried running it from a terminal but also from Spotlight). Maybe I'm missing an entitlement? cc @bruvzg |
|
@Calinou |
|
Current entitlements should be fine, but if you are using multiple bundles with the same id at the same (and all versions of Godot have the same id) permission can sometimes stop working. Removing it from the allowed app list in the system settings (minus button) completly and restarting the app should fix it. |
|
Thank you for this demo, I've added the "waiting for Godot" label because I think it's probably worth waiting for more platforms to have camera feeds supported in the engine's code before merging, otherwise users will get confused and/or annoyed wondering why it doesn't work. |
|
Godot4.5 stable was released, can merge this demo now? |
As seen in OP, pull requests for Windows, iOS and Web support have yet to be merged. I'd wait until the Windows PR is merged at least, as well as the PR that fixes issues in the current macOS implementation. |



This is a demo project for camera feed and camera server.
Supported Platforms
Limitations
Pull requests have been proposed for Windows, iOS and Web.
Add CameraFeed support for Windows godot#105476An alternative implementation using PipeWire for Linux.
macOS and iOS are incomplete due to bugs.
Other bugs
CameraServerfeeds_updatedsignal, and document async behavior godot#108165format_changedandframe_changedsignal for all camera feeds godot#109594format_changedon CameraFeed datatype change godot#111206Preview