Add Needed Signal Connection Steps for Timers #10667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetrapod00
added
enhancement
area:getting started
tetrapod00
reviewed
Feb 11, 2025
Contributor
tetrapod00
left a comment
tetrapod00
left a comment
There was a problem hiding this comment.
In general I'm skeptical of overexplaining and "check that you've done X" type additions to these pages. However I think this one is reasonably justified by reader demand, and doesn't lengthen the page too much.
Co-authored-by: tetrapod <[email protected]>
Co-authored-by: tetrapod <[email protected]>
Contributor
Author
|
Good edits, I am in agreement. |
tetrapod00
approved these changes
Feb 13, 2025
Contributor
tetrapod00
left a comment
tetrapod00
left a comment
There was a problem hiding this comment.
Sorry, I left a grammatical error in the suggestion. Looks good to me otherwise
Contributor
Author
|
Good eye, resolved. |
skyace65
approved these changes
Feb 15, 2025
Contributor
|
Thanks! And congrats on your first merged PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
This PR adds a few needed signal connection steps for setting up timers, steps that are mentioned in passing but not explained in detail; this PR adds these details.
In going through the tutorial, I found these more detailed steps were required to follow in order to correctly proceed. I tested and verified this behavior myself, and thought I would contribute to make the (already good) instructions more clear.
Some commentators also noted that these steps could/ should be added.