-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Describe how 2D lighting and shadows are computed #11364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Describe how 2D lighting and shadows are computed #11364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I am not 100% sold that this in-depth code snippet is appropriate for this page in the docs. But I will defer to the docs team about where the most appropriate place is for this note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the review comments, this looks good to me. I think the added snippet is fine, considering thats its not really huge. :)
Resolved PR comments Co-authored-by: Max Hilbrunner <[email protected]> Co-authored-by: A Thousand Ships <[email protected]>
Related to godotengine/godot#76266. The current behavior is as designed (lighting runs per screen pixel), but this was not documented.
This PR adds a documentation note to the "2D lights and shadows" doc that clarifies how lighting and shadow resolution works in 2D games, particularly for pixel art games.
Not sure if this is the best spot to put the note. Open to suggestions.