Skip to content

Conversation

JellyBoonz
Copy link
Contributor

Related to godotengine/godot#76266. The current behavior is as designed (lighting runs per screen pixel), but this was not documented.

This PR adds a documentation note to the "2D lights and shadows" doc that clarifies how lighting and shadow resolution works in 2D games, particularly for pixel art games.

Not sure if this is the best spot to put the note. Open to suggestions.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am not 100% sold that this in-depth code snippet is appropriate for this page in the docs. But I will defer to the docs team about where the most appropriate place is for this note.

Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the review comments, this looks good to me. I think the added snippet is fine, considering thats its not really huge. :)

Resolved PR comments

Co-authored-by: Max Hilbrunner <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants