Skip to content

Conversation

lawnjelly
Copy link
Member

It's been a while since I wrote any docs so I might need some going over to check this is correct. This is new for 3.6.

Also there's a distinct lack of diagrams, but as these are the most time consuming I'm working on the basis some docs (with diagrams to make later) is better than none at all. If anyone is able to help out with diagrams too, that would be great.

@lawnjelly lawnjelly added this to the 3.x milestone Feb 8, 2024
@lawnjelly lawnjelly marked this pull request as ready for review February 8, 2024 13:17
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content itself looks good but there's two issues.

One we switched over to webp images for the docs, you'll need to convert that. I'd recommend using squoosh

Additionally a lot of these lines are way too long and need to be broken up. stuff like this is an issue
LineTooLong

@lawnjelly
Copy link
Member Author

Have resaved as webp and used approx 80 char limit per line (could not for the notes and tips as sphinx doesn't seem to like line breaks there as it breaks the formatting).

@Calinou Calinou added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features labels Mar 1, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge after applying suggestions.

Also, it might be worth adding a paragraph or note about whether mesh merging works with GridMap and how it interacts with it. As I understand it, mesh merging has no effect on GridMap which already uses MultiMesh internally.

@lawnjelly
Copy link
Member Author

As I understand it, mesh merging has no effect on GridMap which already uses MultiMesh internally.

MergeGroup can in fact bake GridMaps (it is one of the parameters). It defaults to off though, as it is more likely to be useful in GLES2 (which doesn't render MultiMeshes efficiently). This is already noted in the class ref, but I've added a short paragraph at the end.

@mhilbrunner mhilbrunner merged commit 5e1d9c2 into godotengine:3.6 Mar 1, 2024
@mhilbrunner
Copy link
Member

Thanks, and thanks for the reviews everyone! Merged.

@lawnjelly lawnjelly deleted the mergegroup branch March 2, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants