-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
MergeGroups initial docs #8924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MergeGroups initial docs #8924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content itself looks good but there's two issues.
One we switched over to webp images for the docs, you'll need to convert that. I'd recommend using squoosh
Additionally a lot of these lines are way too long and need to be broken up. stuff like this is an issue
4eebccd
to
004f003
Compare
Have resaved as webp and used approx 80 char limit per line (could not for the notes and tips as sphinx doesn't seem to like line breaks there as it breaks the formatting). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to merge after applying suggestions.
Also, it might be worth adding a paragraph or note about whether mesh merging works with GridMap and how it interacts with it. As I understand it, mesh merging has no effect on GridMap which already uses MultiMesh internally.
|
Thanks, and thanks for the reviews everyone! Merged. |
It's been a while since I wrote any docs so I might need some going over to check this is correct. This is new for 3.6.
Also there's a distinct lack of diagrams, but as these are the most time consuming I'm working on the basis some docs (with diagrams to make later) is better than none at all. If anyone is able to help out with diagrams too, that would be great.