Internationalize the Features and Download pages #1026
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a French translation for both pages as well. TODO: - Make translations visible on the Download page by fixing URLs (`/fr/download/linux` is not being generated, only `/fr/download` is). - Change links to pages to use localized variants according to the current page language. - Make the language dropdown preserve the page you're currently looking at, instead of redirecting you to the homepage. `window.location.pathname` is supposed to do this, but it doesn't work after you use it once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a French translation for both pages as well.
Preview
TODO
/fr/download/linuxis not being generated, only/fr/downloadis).localize: ["en", "fr"]tocollections/_download/linux.mdto no avail.window.location.pathnameis supposed to do this, but it doesn't work after you use it once.