fix: display ExifVersion/FlashpixVersion as version strings#26
Merged
Conversation
ExifVersion and FlashpixVersion are stored as 4 ASCII bytes (e.g., "0221" for EXIF 2.21) but were being returned as raw byte slices. This fix converts them to human-readable strings. Also adds handling for InteroperabilityVersion in the same way. Fixes #17 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
tech-lead-02 Review: LGTM ✅Simple, clean fix for version string display. ✅ ExifVersion: Ready for merge once CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[]byte{48, 50, 50, 49}→"0221"[]byte{48, 49, 48, 48}→"0100"Fixes #17
Test plan
🤖 Generated with Claude Code