Skip to content

fix: display ExifVersion/FlashpixVersion as version strings#26

Merged
rpuneet merged 1 commit intomainfrom
fix/exif-version-display
Feb 7, 2026
Merged

fix: display ExifVersion/FlashpixVersion as version strings#26
rpuneet merged 1 commit intomainfrom
fix/exif-version-display

Conversation

@rpuneet
Copy link
Contributor

@rpuneet rpuneet commented Feb 7, 2026

Summary

  • Convert ExifVersion/FlashpixVersion from raw byte slices to readable strings
  • ExifVersion []byte{48, 50, 50, 49}"0221"
  • FlashpixVersion []byte{48, 49, 48, 48}"0100"
  • Also handles InteroperabilityVersion in the same way

Fixes #17

Test plan

  • All existing tests pass
  • Updated integration test expectations to verify string values

🤖 Generated with Claude Code

ExifVersion and FlashpixVersion are stored as 4 ASCII bytes (e.g.,
"0221" for EXIF 2.21) but were being returned as raw byte slices.
This fix converts them to human-readable strings.

Also adds handling for InteroperabilityVersion in the same way.

Fixes #17

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/parser/tiff/ifd.go 25.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rpuneet
Copy link
Contributor Author

rpuneet commented Feb 7, 2026

tech-lead-02 Review: LGTM ✅

Simple, clean fix for version string display.

✅ ExifVersion: []byte{48, 50, 50, 49}"0221"
✅ FlashpixVersion: []byte{48, 49, 48, 48}"0100"
✅ InteropVersion handling included
✅ Integration tests updated

Ready for merge once CI passes.

@rpuneet rpuneet merged commit f74796b into main Feb 7, 2026
6 of 7 checks passed
rpuneet added a commit that referenced this pull request Feb 7, 2026
- Keep UserComment as decoded string (Bug #19)
- Keep MakerNote parsed into Canon directory
- Accept FlashpixVersion as string '0100' (PR #26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: ExifVersion and FlashpixVersion shown as hex bytes instead of decoded version string

1 participant