fix(makernote): register Canon parser in TIFF parser#34
Closed
fix(makernote): register Canon parser in TIFF parser#34
Conversation
Fixes #29 The Canon MakerNote parser was merged (PR #24) but not registered in the MakerNote registry, causing Canon metadata to not be extracted. Canon must be registered LAST as it has no header and uses IFD structure validation as fallback detection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Always add raw MakerNote tag to ExifIFD (backward compatibility) - Add Canon directory expectation to CR2 integration test with 28 tags - Verify correct Canon tag names (CameraSettings, ShotInfo, etc.) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Closing as duplicate - Canon registration is now included in the rebased codebase via other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29
CRITICAL HOTFIX - Canon MakerNote parser was merged but not registered.
Root Cause
PR #24 added the Canon parser implementation but the registration line was missing from
tiff.go:Changes
canonpackage importcanon.New()after Sony (Canon must be last as fallback)Verification
Now shows Canon MakerNote tags:
Test plan
make buildpasses🤖 Generated with Claude Code