Remove f32-qc4w and f32-qc8w #8692
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
These are unused, and have two serious issues: - They expect uint4, not int4. - They add the bias before quantization scaling instead of after (inconsistent with the rest of the gemms) Other work is uncovering and requiring workarounds for these issues, we should just remove these until we can fix them. PiperOrigin-RevId: 781160003
copybara-service
bot
force-pushed
the
test_781160003
branch
from
11de7a4 to
fad1e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove f32-qc4w and f32-qc8w
These are unused, and have two serious issues:
Other work is uncovering and requiring workarounds for these issues, we should just remove these until we can fix them.