Fix incorrect declarations #8812
Open
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cyy <[email protected]>
fbarchard
reviewed
Aug 25, 2025
src/xnnpack/internal.h
Outdated
| @@ -103,7 +103,7 @@ enum xnn_status xnn_setup_batch_matrix_multiply_nc_qp8_f32_qc8w( | |||
| xnn_operator_t batch_matrix_multiply_op, // | |||
| void* workspace, // | |||
| const int8_t* input_a, // | |||
| const int8_t* input_b, // | |||
| const float* input_b, // | |||
There was a problem hiding this comment.
this doesnt look right. the input_b is qc8w which is int8_t
There was a problem hiding this comment.
But the function definition in src/operators/batch-matrix-multiply-nc.c uses const float* input_b.
PS: it looks like I should change the definition.
Signed-off-by: cyy <[email protected]>
Signed-off-by: cyy <[email protected]>
fbarchard
approved these changes
Sep 12, 2025
|
I tried lto and GCC or Clang complained it. It still can't build with lto after these fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.