fix: remove __import__ from sandbox builtins in policy-as-code agent#1340
Open
vnykmshr wants to merge 1 commit intogoogle:mainfrom
Open
fix: remove __import__ from sandbox builtins in policy-as-code agent#1340vnykmshr wants to merge 1 commit intogoogle:mainfrom
vnykmshr wants to merge 1 commit intogoogle:mainfrom
Conversation
The restricted builtins dict included the real __import__ function, bypassing the AST validator via subscript access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1339
Removes
__import__from the sandbox builtins dict. The AST validator catches direct calls but not subscript-style access via the builtins dict.json/re/datetime are already injected into the sandbox namespace so import statements aren't needed in generated code.
Test added.