Recompression

[riknel]

Faster and more efficient recompression using previous compression artifacts such as backward references and block splits.

[yoavweiss]

A few random comments

[yoavweiss]

A few comments that seem to coalesce to a few categories:

• Style nits
• Out-of-bound checks - you need to make sure that all your array reads and writes are done within bounds, even if e.g. the input to the program is invalid (e.g. an attacker sends a corrupted brotli file), or, to a lesser extent, if the input to a function is invalid (e.g. a future programmer calls it with the wrong values). The former case needs to be handled gracefully, without crashing. The latter case, needs to be assert() against, at the very least. If this requires work that goes beyond the prototype's scope, leave a TODO to make sure this happens before the code's productization.
• Magic numbers - they make it hard to read the code and understand what it means. Constants with descriptive names are better
• Prototype-level shortcuts - No need to fix those IMO, but you do need to call them out (e.g. overly large allocations)

Also, I see a bunch of allocations but no free() to go along with them...

[ahorek]

to avoid warnings, you should add
#include <stdlib.h>
at the top of the file