Skip to content

Update cisco.py to handle using raw protocol numbers in policy #170 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update cisco.py to handle using raw protocol numbers in policy #170 #224

wants to merge 2 commits into from

Conversation

jrachele
Copy link

  • Allowed passing along of raw numeric protocol in Cisco generator, using str.isnumeric()
  • Added test to ensure that this feature works
  • Minor cleanup of errant print statement leftover in other test [cisco_test.py:881]

@google-cla google-cla bot added the cla: yes label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrachele @kaibabbob @ggiesen