Do not copy immarg attribute in LowerAddrSpaceCast#1351
Draft
bmanga wants to merge 1 commit intogoogle:mainfrom
Draft
Do not copy immarg attribute in LowerAddrSpaceCast#1351bmanga wants to merge 1 commit intogoogle:mainfrom
bmanga wants to merge 1 commit intogoogle:mainfrom
Conversation
rjodinchr
reviewed
May 15, 2024
Collaborator
rjodinchr
left a comment
rjodinchr
left a comment
There was a problem hiding this comment.
Have you considered moving ReplaceLLVMIntrinsicsPass earlier in the flow (before first LowerAddrSpaceCastPass) to get rid of those memcpy?
It might not be possible if memcpy gets generated by other passes (instcombine?).
| ; RUN: clspv-opt %s -o %t.ll --passes=lower-addrspacecast | ||
| ; RUN: FileCheck %s < %t.ll | ||
|
|
||
| ; CHECK: declare void @_Z21llvm.memcpy.p0.p4.i32PPU3AS1memcpy.p0.p4.i32(ptr noalias nocapture writeonly, ptr addrspace(1) noalias nocapture readonly, i32, i1) #0 |
Collaborator
There was a problem hiding this comment.
Is clspv really able to deal with such a function to emit anything valid?
Maybe because it contains llvm.memcpy it works?
Contributor
Author
There was a problem hiding this comment.
Yeah, the replace intrinsics pass seems prepared for this, as it looks at the function name containing "llvm.memcpy".
rjodinchr
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1350