Migrate to central-publishing-maven-plugin and off oss-parent.
#493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_788519238
branch
from
318d345 to
64a97b9
Compare
I missed these files in cl/782079419 because I was looking for... maybe `maven-deploy-plugin`? I forget, but apparently I was looking for _something_ that these projects don't declare as a plugin. (They haven't need to declare the plugin because they were inheriting it from `oss-parent`.) Then this seemed like a good time to finally migrate the rest of our projects off `oss-parent`. See previous changes like cl/350197931. I've made the same changes here. I've marginally improved upon both the CLs I mentioned before: - I omit `<groupId>org.apache.maven.plugins</groupId>`, since that is the default. - I omit `<publishingServerId>central</publishingServerId>`, since that is the default. Also, I was careful not to copy `<failOnError>false</failOnError>` from `auto/value` and `auto/factory`. We don't seem to use it in our other projects, and it wasn't part of `oss-parent`. Also, I omitted a `maven-javadoc-plugin` entry in `guava_beta_checker`, which already configured that plugin. I could totally believe that some part of this CL will break a release somewhere. I'm not sure we'll notice until we try to publish a release. But that would be only a lateral move from where we likely are now, since we already can't publish a release until we perform the OSSRH->Central migration. I could also totally believe that we could do things better here. Possible examples include: - Move at least `maven-source-plugin` and `maven-javadoc-plugin` out of the release profile and into the main configuration (similar to `maven-javadoc-plugin` in `guava_beta_checker`). Or, alternatively, remove them entirely. (But removing them might cause Maven to select whatever the latest release is, and that's not great. It might also use slightly different settings that we've chosen; I'm not sure.) - Omit the `sonatype-nexus-snapshots` configuration from projects that we don't publish snapshots for. - Write our own common parent POM, as we've contemplated before. RELNOTES=n/a PiperOrigin-RevId: 788538710
copybara-service
bot
force-pushed
the
test_788519238
branch
from
64a97b9 to
f74b3d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to
central-publishing-maven-pluginand offoss-parent.I missed these files in cl/782079419 because I was looking for... maybe
maven-deploy-plugin? I forget, but apparently I was looking for something that these projects don't declare as a plugin. (They haven't need to declare the plugin because they were inheriting it fromoss-parent.)Then this seemed like a good time to finally migrate the rest of our projects off
oss-parent. See previous changes like cl/350197931. I've made the same changes here.I've marginally improved upon both the CLs I mentioned before:
<groupId>org.apache.maven.plugins</groupId>, since that is the default.<publishingServerId>central</publishingServerId>, since that is the default.Also, I was careful not to copy
<failOnError>false</failOnError>fromauto/valueandauto/factory. We don't seem to use it in our other projects, and it wasn't part ofoss-parent.Also, I omitted a
maven-javadoc-pluginentry inguava_beta_checker, which already configured that plugin.I could totally believe that some part of this CL will break a release somewhere. I'm not sure we'll notice until we try to publish a release. But that would be only a lateral move from where we likely are now, since we already can't publish a release until we perform the OSSRH->Central migration.
I could also totally believe that we could do things better here. Possible examples include:
maven-source-pluginandmaven-javadoc-pluginout of the release profile and into the main configuration (similar tomaven-javadoc-plugininguava_beta_checker). Or, alternatively, remove them entirely. (But removing them might cause Maven to select whatever the latest release is, and that's not great. It might also use slightly different settings that we've chosen; I'm not sure.)sonatype-nexus-snapshotsconfiguration from projects that we don't publish snapshots for.RELNOTES=n/a