Skip to content

vi: translate Default trait #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2024
Merged

vi: translate Default trait #2447

merged 1 commit into from
Oct 27, 2024

Conversation

@l0ngvh
Copy link
Contributor

@l0ngvh l0ngvh commented Oct 20, 2024

Translate the Default chapter of the std-trait section to Vietnamese

qu-ngx
qu-ngx reviewed Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am running some tests on your PR first. I will get back to this PR later when they are done.

qu-ngx
qu-ngx reviewed Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Please feel free to correct me if I'm wrong anywhere:)) Tks!

@l0ngvh l0ngvh requested a review from qu-ngx October 27, 2024 11:11
qu-ngx
qu-ngx approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contributions!

@qu-ngx qu-ngx merged commit 8873e3e into google:main Oct 27, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qu-ngx qu-ngx qu-ngx approved these changes

@daivinhtran daivinhtran Awaiting requested review from daivinhtran

Assignees

No one assigned

Labels

translation/vi translation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@l0ngvh @qu-ngx