Minor fixes in new lifetimes section #2965
Open
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribozavr
approved these changes
Oct 31, 2025
fw-immunant
reviewed
Nov 4, 2025
|
|
||
| - The "help" message in the error notes that we can add a lifetime bound | ||
| `'b: 'a` to say that `'b` will live at least as long as `'a`, which would then | ||
| allow us to return `query`. This is an example of lifetime "variance", which |
Collaborator
There was a problem hiding this comment.
This is lifetime subtyping; variance only has to do with the way the subtyping relation is reversed for function argument types relative to function return types.
fw-immunant
reviewed
Nov 4, 2025
| --- | ||
|
|
||
| # Lifetimes in Function Calls | ||
| # Lifetimes Elision |
Collaborator
There was a problem hiding this comment.
This should be "Lifetime Elision" (singular).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gribozavr I had a couple more fixes for #2964 that I didn't push until after you merged the branch.