build_android: Only build replay and layer #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gradle finished but there were CMake errors. EDIT: Fixed. Needed to build both layer and release explicitly |
Last subtree update, we got two new Android targets: - multi-win-replay - quest_replay As a result, build times doubled. In order to reduce build times, only compile parts of GFXR that we use. Since replay depends on the capture layer, asking Gradle to build replay will cause both to be built
footballhead
force-pushed
the
build_android_gfxr_replay_only
branch
from
420001b to
1825883
Compare
footballhead
commented
Sep 23, 2025
…oid_gfxr_replay_only
replay's dependency on layer will only build AAR in debug. In release, need to build both. Fortunately, building both can be accomplished with one command.
footballhead
changed the title
|
Last main Android build took 27m: https://github.com/google/dive/actions/runs/17959883734/job/51080514162 This Android build took 13m 12s: https://github.com/google/dive/actions/runs/17979996130/job/51143222902?pr=327 |
wangra-google
approved these changes
Sep 24, 2025
angela28chen
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last subtree update, we got two new Android targets:
As a result, build times doubled. In order to reduce build times, only compile parts of GFXR that we use. This also means that we don't compile the test apps