Add unit test for AndroidTraceManager frame trace #391
+89
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a unit test for google#385. Without the fix, the test fails. With the fix, the test passes. This additionally required: - removing an unused #include - splitting trace_mgr into its own target so that it could be more granularly included in the test
footballhead
commented
Sep 22, 2025
elviscapiaq
reviewed
Sep 22, 2025
angela28chen
previously approved these changes
Sep 22, 2025
elviscapiaq
approved these changes
Oct 1, 2025
angela28chen
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unit test for #385. Without the fix, the test fails. With the fix, the test passes.
This additionally required: