docs: give a example to show how to import glog by add_subdirectory#1067
docs: give a example to show how to import glog by add_subdirectory#1067valaxkong wants to merge 0 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sergiud
left a comment
sergiud
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I do not believe we should mirror the CMake documentation. An example of using FetchContent is better suited for the Wiki section of glog.
README.rst
Outdated
| project by replacing the :cmake:`find_package` call from the previous snippet by | ||
| :cmake:`add_subdirectory`. The :cmake:`glog::glog` target is in this case an | ||
| :cmake:`ALIAS` library target for the ``glog`` library target. | ||
| Here is an example which using :cmake:`FetchContent` and :cmake:`add_subdirectory` |
There was a problem hiding this comment.
Do we really need to show a complete example for how to use FetchContent? This is essentially an exact mirror of the example from CMake reference documentation. In that sense, a single sentence with a link to FetchContent example should be sufficient.
2 participants
Change-Id: I2e77e155c134d36f36ff38f3d3bc396a48b07ff6