Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
+ Coverage 63.57% 64.08% +0.50%
==========================================
Files 20 20
Lines 2578 2578
Branches 894 906 +12
==========================================
+ Hits 1639 1652 +13
+ Misses 671 662 -9
+ Partials 268 264 -4 |
I have put a basic description of |
sergiud
left a comment
There was a problem hiding this comment.
Thank you for updating the docs. However, there seems to some kind of editing error.
| There's also `#!cpp VLOG_IS_ON(n)` "verbose level" condition macro. This macro | ||
| returns `#!cpp true` when the `--v` is equal to or greater than `n`. The macro can be | ||
| used as follows: | ||
| returns `#!cpp true` when the matching `--vmodule`, else `--v` is equal to or greater than `n`. |
There was a problem hiding this comment.
This description seems to be broken now. The else part looks out of place. What am I missing?
There was a problem hiding this comment.
I was trying to convey the fact that if there is no matching --vmodule then --v is used. Should we just change it to "when the level is equal to or greater than"?
Fix the comment about
SetVLOGLevelaccording to #650 which added support for updating vmodule levels after vmodule level has been cached.Fixes #858