Skip to content

fix: Org/Enterprise UpdateRepositoryRulesetClearBypassActor sends empty array #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
+8 −2
Merged

fix: Org/Enterprise UpdateRepositoryRulesetClearBypassActor sends empty array #3796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion github/enterprise_rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ func (s *EnterpriseService) UpdateRepositoryRuleset(ctx context.Context, enterpr
func (s *EnterpriseService) UpdateRepositoryRulesetClearBypassActor(ctx context.Context, enterprise string, rulesetID int64) (*Response, error) {
u := fmt.Sprintf("enterprises/%v/rulesets/%v", enterprise, rulesetID)

rsClearBypassActor := rulesetClearBypassActors{}
rsClearBypassActor := rulesetClearBypassActors{
BypassActors: []*BypassActor{},
}

req, err := s.client.NewRequest("PUT", u, rsClearBypassActor)
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions github/enterprise_rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1775,6 +1775,7 @@ func TestEnterpriseService_UpdateRepositoryRulesetClearBypassActor(t *testing.T)

mux.HandleFunc("/enterprises/e/rulesets/84", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testBody(t, r, `{"bypass_actors":[]}`+"\n")
fmt.Fprint(w, `{
"id": 84,
"name": "test ruleset",
Expand Down
4 changes: 3 additions & 1 deletion github/orgs_rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ func (s *OrganizationsService) UpdateRepositoryRuleset(ctx context.Context, org
func (s *OrganizationsService) UpdateRepositoryRulesetClearBypassActor(ctx context.Context, org string, rulesetID int64) (*Response, error) {
u := fmt.Sprintf("orgs/%v/rulesets/%v", org, rulesetID)

rsClearBypassActor := rulesetClearBypassActors{}
rsClearBypassActor := rulesetClearBypassActors{
BypassActors: []*BypassActor{},
}

req, err := s.client.NewRequest("PUT", u, rsClearBypassActor)
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions github/orgs_rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1593,6 +1593,7 @@ func TestOrganizationsService_UpdateRepositoryRulesetClearBypassActor(t *testing

mux.HandleFunc("/orgs/o/rulesets/21", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testBody(t, r, `{"bypass_actors":[]}`+"\n")
fmt.Fprint(w, `{
"id": 21,
"name": "test ruleset",
Expand Down
Loading