Migrate more code to use UndeclaredThrowableException.
#7451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And generally make our handling more consistent (`throwIfUnchecked` + `UndeclaredThrowableException` with appropriate comments). This is mostly a no-op (assuming that the undeclared throwables are in fact impossible :)), but I note that the old `ChecksumHashFunction` code appears to be wrapping any _`RuntimeException`_ in an `AssertionError`, which would be bad if there were a practical chance of such a thing (though hopefully there is not). Compare cl/686064398. I suspect that we could find yet more similar code. RELNOTES=n/a PiperOrigin-RevId: 686883397
copybara-service
bot
force-pushed
the
test_686523874
branch
from
c0be120 to
2212495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate more code to use
UndeclaredThrowableException.And generally make our handling more consistent (
throwIfUnchecked+UndeclaredThrowableExceptionwith appropriate comments).This is mostly a no-op (assuming that the undeclared throwables are in fact impossible :)), but I note that the old
ChecksumHashFunctioncode appears to be wrapping anyRuntimeExceptionin anAssertionError, which would be bad if there were a practical chance of such a thing (though hopefully there is not).Compare cl/686064398. I suspect that we could find yet more similar code.
RELNOTES=n/a