Prepare for usage of ReflectionFreeAssertThrows from more packages:
#7455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_686938704
branch
from
5df12ee to
8a1c90e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for usage of
ReflectionFreeAssertThrowsfrom more packages:AbstractPackageSanityTestsignore the class for simplicity. (But also add null checks (which solve only part of the problem) toReflectionFreeAssertThrowsbecause why not.)util.concurrenttypes so that we can also removeutil.concurrentdeps (mostly added during cl/675634517 and cl/686155720). I'll include support for those types in the packages that actually need it.RELNOTES=n/a