Meta-annotate Subscribe with [@Keep](https://javadoc.io/doc/com.google.errorprone/error_prone_annotations/latest/com/google/errorprone/annotations/Keep.html).
#7873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_783461948
branch
2 times, most recently
from
9ec6df9 to
9b24830
Compare
…oogle.errorprone/error_prone_annotations/latest/com/google/errorprone/annotations/Keep.html). It's [already treated that way by the most relevant Error Prone check](https://github.com/google/error-prone/blob/43759cd54556b70057f617f2da8df433f3961a98/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java#L117), but [we prefer not to have to hard-code such things](https://github.com/google/error-prone/blob/43759cd54556b70057f617f2da8df433f3961a98/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java#L102), and theoretically there's a better chance that _other_ tools would recognize `@Keep` than `@Subscribe`. RELNOTES=n/a PiperOrigin-RevId: 783771120
copybara-service
bot
force-pushed
the
test_783461948
branch
from
9b24830 to
55a0c24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta-annotate
Subscribewith@Keep.It's already treated that way by the most relevant Error Prone check, but we prefer not to have to hard-code such things, and theoretically there's a better chance that other tools would recognize
@Keepthan@Subscribe.RELNOTES=n/a