Apply maven BestPractices #7959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
RSPEC-S1144
branch
2 times, most recently
from
65725f8 to
29f15f3
Compare
Pankraz76
commented
Aug 31, 2025
Pankraz76
commented
Aug 31, 2025
Pankraz76
commented
Aug 31, 2025
Pankraz76
force-pushed
the
RSPEC-S1144
branch
2 times, most recently
from
a9d7078 to
1d58159
Compare
Pankraz76
changed the title
Rewrite & PMD covering S1144: Unused "private" methods should be removedRewrite & PMD covering S1128: Unnecessary "using" should be removed
Pankraz76
changed the title
Rewrite & PMD covering S1128: Unnecessary "using" should be removedRewrite & PMD
Pankraz76
changed the title
Rewrite & PMD
Pankraz76
force-pushed
the
RSPEC-S1144
branch
from
944326c to
2269819
Compare
|
I stand by #7916 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi im wondering if there is any benefit and chance of using: