Add required information and plugin in guava-pom/pom.xml.
#8005
+84
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Those changes address these errors from my attempted release: ``` pkg:maven/com.google.guava/[email protected]?type=pom: - Missing signature for file: guava-bom-33.5.0-jre.pom pkg:maven/com.google.guava/[email protected]: - SCM URL is not defined - Developers information is missing ``` (I was initially confused because the errors were listed in two sections, which made me think that one of them was coming from a different `pom.xml`. But once I actually read them, I saw that they're both from `guava-bom`. That makes sense, since it's the project that doesn't inherit from `guava-parent` and the one where we mostly recently ripped out `oss-parent` (87976cd).) One thing that I needed to do was copy over developer information, so I figured it was time to [update](https://x.com/kevinb9n/status/1745890746350321818) there. As noted in the comments, Guava had had a very large number of developers over many years, and that is not even fully accounted for in [the GitHub contributor stats](https://github.com/google/guava/graphs/contributors): - Many internal contributors didn't have their authorship made visible in GitHub. - I get unjustified credit for "authoring" others' CLs simply because I was the one to kick off our old, semi-automated internal->GitHub migrator. RELNOTES=n/a PiperOrigin-RevId: 808257208
copybara-service
bot
force-pushed
the
test_808160221
branch
from
64c159c to
e9ea5a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add required information and plugin in
guava-pom/pom.xml.Those changes address these errors from my attempted release:
(I was initially confused because the errors were listed in two sections, which made me think that one of them was coming from a different
pom.xml. But once I actually read them, I saw that they're both fromguava-bom. That makes sense, since it's the project that doesn't inherit fromguava-parentand the one where we mostly recently ripped outoss-parent(cl/786274873).)One thing that I needed to do was copy over developer information, so I figured it was time to update there. As noted in the comments, Guava had had a very large number of developers over many years, and that is not even fully accounted for in the GitHub contributor stats:
RELNOTES=n/a