Skip to content

Conversation

miladsade96
Copy link

Changes:

  1. Correcting state management bug
  2. Handling null value properly

Copy link

google-cla bot commented Sep 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@miladsade96
Copy link
Author

miladsade96 commented Sep 18, 2025

I have signed the google cla, but still shows me as unsigned. Is there any way to force cla/google to reload or recheck the cla status?

@cpovirk
Copy link
Member

cpovirk commented Sep 18, 2025

I clicked the link for rescanning it from https://github.com/google/guava/pull/8006/checks?check_run_id=50725139081, and now it's showing as passing.

If this PR fixes a bug, please add a test that fails without the PR and passes with it.

@miladsade96
Copy link
Author

@cpovirk
I refactored the code but the behavior is the same as before.
Is it necessary to add more tests to the test class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants