Fix crash on single-lens devices by validating initial lens facing#474
Merged
Fix crash on single-lens devices by validating initial lens facing#474
Conversation
This tests that the camera can start and the switch camera button is disabled when it only has a single lens.
Previously, the app could crash if the stored or default preference
was set to a lens (e.g., BACK) that did not exist on the device
(e.g., a front-facing only device).
This change adds a validation step during `CameraXCameraSystem`
initialization:
* It checks if the requested `cameraLensFacing` is actually
present in the list of available lenses.
* If the requested lens is unavailable, it falls back to the first
available lens found.
* Updates usage of `cameraAppSettings` to `validatedAppSettings`
when generating illuminants and applying constraints to ensure
consistency throughout the initialization flow.
This ensures the app starts correctly on devices with restricted
camera configurations or single-lens setups.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a crash on devices with single or non-standard camera configurations by validating the lens facing preference during initialization. The core logic change in CameraXCameraSystem is sound, ensuring the app falls back to an available lens if the preferred one is missing. The addition of SingleLensModeTest provides good test coverage for this scenario, and the refactoring in UiTestUtil improves code clarity. I have one minor suggestion to make the validation logic in CameraXCameraSystem slightly more idiomatic.
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraSystem.kt
Show resolved
Hide resolved
Kimblebee
approved these changes
Feb 12, 2026
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraSystem.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the app could crash if the stored or default preference
was set to a lens (e.g., BACK) that did not exist on the device
(e.g., a front-facing only device).
This change adds a validation step during
CameraXCameraSysteminitialization:
cameraLensFacingis actuallypresent in the list of available lenses.
available lens found.
cameraAppSettingstovalidatedAppSettingswhen generating illuminants and applying constraints to ensure
consistency throughout the initialization flow.
This ensures the app starts correctly on devices with restricted
camera configurations or single-lens setups.