-
Notifications
You must be signed in to change notification settings - Fork 35
Add crates index manager abstraction #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,836
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
074b92b
to
3c65cd3
Compare
wbxyz
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Baring race conditions in the IndexManager, this lgtm.
3a34638
to
408f0b2
Compare
wbxyz
approved these changes
Sep 2, 2025
9297d2b
to
1dcf6d2
Compare
wbxyz
approved these changes
Sep 4, 2025
e2c097f
to
9e8e725
Compare
dd57d58
to
7f00563
Compare
The full crates.io index corpus is too large and growing too fast to realistically assume we can have access to it all at once for inference purposes. This new component enables us to keep a fixed-size cache of snapshots on disk while rotating the least used snapshots out when other snapshots are requested. We unconditionally keep the current (i.e. non-archived) index cloned given it is the newest and most likely to be requested during inference. The interface also supports loading index portions from an existing filesystem which means it can also be used transiently to mediate access to these resources.
7f00563
to
b048d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full crates.io index corpus is too large and growing too fast to
realistically assume we can have access to it all at once for inference
purposes. This new component enables us to keep a fixed-size cache of
snapshots on disk while rotating the least used snapshots out when other
snapshots are requested. We unconditionally keep the current (i.e.
non-archived) index cloned given it is the newest and most likely to be
requested during inference.
The interface also supports loading index portions from an existing
filesystem which means it can also be used transiently to mediate access
to these resources.