Tracing which stabilizer is taking effect #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
suggested changes
Sep 12, 2025
wbxyz
reviewed
Sep 12, 2025
pkg/archive/zip.go
Outdated
| } | ||
| newArchiveHash := getArchiveHash(&mr) | ||
| if originalArchiveHash != newArchiveHash { | ||
| println("Stabilizer taking effect:", currentStabName) |
There was a problem hiding this comment.
Rather than printing these types, what do you think of collecting them and returning somehow? Eventually we can include the stabilizers used during comparison as part of the attestation.
There was a problem hiding this comment.
I agree, collecting them from stderr is not great. Do you have any suggestion?
There was a problem hiding this comment.
I think they could be appended to a slice and that slice could be returned by this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version just prints out when an archive has a different hash after applying a stabilizer. Depending on how we want to deal with this info, we can think about a different output