Add service to host crates registry queries #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full crates.io index corpus is too large and growing too fast to realistically assume we can have access to it all at once for inference purposes. This new component enables us to keep a fixed-size cache of snapshots on disk while rotating the least used snapshots out when other snapshots are requested. We unconditionally keep the current (i.e. non-archived) index cloned given it is the newest and most likely to be requested during inference. The interface also supports loading index portions from an existing filesystem which means it can also be used transiently to mediate access to these resources. stacked-commit: true
stacked-commit: true
msuozzo
force-pushed
the
push-smpzlxrnzlwl
branch
from
2662d6e to
be8b79f
Compare
wbxyz
approved these changes
Sep 12, 2025
|
|
||
| var ( | ||
| cacheDir = flag.String("cache-dir", "/tmp/registry-cache", "Directory to cache registry indices") | ||
| maxSnapshots = flag.Int("max-snapshots", 18, "Maximum number of snapshot indices to cache") |
There was a problem hiding this comment.
nit: Where did 18 come from as the default? Based on approximate size of each?
| image = data.google_artifact_registry_docker_image.crates-registry.self_link | ||
| args = [ | ||
| "--cache-dir=/cache", | ||
| "--max-snapshots=16", |
There was a problem hiding this comment.
nit: Is this based on amount of memory and/or volume size? Probably worth a comment.
| ) | ||
|
|
||
| // FindRegistryCommitRequest represents a request to find a registry commit | ||
| type FindRegistryCommitRequest struct { |
There was a problem hiding this comment.
Is there a reason this request and response type is defined in the service implementation library rather than schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.